Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add additional text and disclaimer to Publish Dataset Modal, to match behavior in JSF.
Which issue(s) this PR closes:
Special notes for your reviewer:
This PR depends on IQSS/dataverse-client-javascript#422, when that PR is merged, package.json needs to be updated
Suggestions on how to test this:
To setup, use the API to add the custom text and disclaimer, for example:
curl -X PUT -d'Please agree to this disclaimer text before publishing' http://localhost:8080/api/admin/settings/:PublishDatasetDisclaimerText
curl -X PUT -d'Additional custom text that appears in the modal' http://localhost:8080/api/admin/settings/:DatasetPublishPopupCustomText
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
It should match the JSF publish dataset modal:

Is there a release notes or changelog update needed for this change?:
yes
Additional documentation: